Add minimal support for BFloat16 dtype.

PyO3 / rust-numpy

PyO3-based Rust bindings of the NumPy C-API

BSD 2-Clause "Simplified" License

1.11k stars 106 forks source link

Add minimal support for BFloat16 dtype. #381

Closed adamreichold closed 1 year ago

adamreichold commented 1 year ago

Closes #380

adamreichold commented 1 year ago

The issue with the "careful" job seems unrelated to the change at hand.

adamreichold commented 1 year ago

@kngwyu Not sure what to do about tests here? Ship it without any tests? Install Tensorflow in the CI? Something else?

kngwyu commented 1 year ago

How about using ml_dtypes? I have no experience with this, but it looks suitable for CI because it only depends on numpy.

adamreichold commented 1 year ago

How about using ml_dtypes? I have no experience with this, but it looks suitable for CI because it only depends on numpy.

Yes, this is a nice self-contained one and the CI seems to be happy using it.

What do you think about the change itself? Would you be ok with merging while the careful job is still broken due to the rust-toolchain action being unable to install Rust nightly?

kngwyu commented 1 year ago

Would you be ok with merging while the careful job is still broken due to the rust-toolchain action being unable to install Rust nightly?

I'm personally OK to go ahead, but just waiting seems also OK if the nightly will come back soon. (I hope it will be fixed tomorrow, though sometimes it can take some time...

adamreichold commented 1 year ago

I'm personally OK to go ahead, but just waiting seems also OK if the nightly will come back soon. (I hope it will be fixed tomorrow, though sometimes it can take some time...

Yeah, let's wait...