search

PyO3 / rust-numpy

PyO3-based Rust bindings of the NumPy C-API
BSD 2-Clause "Simplified" License
1.07k stars 98 forks source link

Bump py03 #430

Closed alexespencer closed 3 weeks ago

alexespencer commented 1 month ago

Bumps py03 to 0.22.0

https://github.com/PyO3/pyo3/releases/tag/v0.22.0

alexespencer commented 1 month ago

Looks like a number of changes will be needed, including PyNativeType being behind the py03 feature gil-refs, as well as changes to calls like as_borrowed(). Will try to spend some time researching this (simultaneously new to rust + pyo3) so would appreciate pointers

bschoenmaeckers commented 1 month ago

Looks like a number of changes will be needed, including PyNativeType being behind the py03 feature gil-refs, as well as changes to calls like as_borrowed(). Will try to spend some time researching this (simultaneously new to rust + pyo3) so would appreciate pointers

Because PyNativeType is not available without the gil-refs feature you should implement all methods for Bound<Self> instead of &Self.

alexespencer commented 3 weeks ago

Closing in favour of #431