search

PyO3 / rust-numpy

PyO3-based Rust bindings of the NumPy C-API
BSD 2-Clause "Simplified" License
1.11k stars 106 forks source link

Update pyo3 to 0.22.0 #431

Closed bschoenmaeckers closed 2 months ago

bschoenmaeckers commented 3 months ago

This is the first iteration of the process to update to pyo3 0.22. The first step is to make the current code compile against the new version. In following MR we should feature gate the deprecated gil-refs api's used and implement every method against the Bound wrapper.

bschoenmaeckers commented 3 months ago

I've moved all code using the gil-refs api behind the gil-refs feature so it compiles without it as well now. Please review

bschoenmaeckers commented 3 months ago

I'm not sure about the py-clone feature, should it be enabled or is there a better way?

JRRudy1 commented 3 months ago

I am eager to upgrade to PyO3 0.22 but can't until numpy supports it, so let me know if there are any tasks I can take on to help move this forward! Thanks for getting it started :)

bschoenmaeckers commented 2 months ago

Closing in fever of #435