search

PyOCL / OpenCLGA

A Python Library for Genetic Algorithm on OpenCL
MIT License
119 stars 34 forks source link

reverse the min/max calculation #18

Closed john-hu closed 7 years ago

john-hu commented 7 years ago

Currently, we use TSP as an example which tries to minimize the path. This doesn't follow the convention of GA. GA tries maximize the fitness value. We should reverse our implementation to follow the convention of GA.

kilikkuo commented 7 years ago

https://github.com/PyOCL/oclGA/commit/6a297d24ca82ced5ec1bdf80ab6977f30799ba1b https://github.com/PyOCL/oclGA/commit/6a1281539423615302dec65dcd9ba3f9abcf6c6f

john-hu commented 7 years ago

@kilikkuo

You can close an issue with the commit with the sentence like this in github:

Fixed #18 - what had you done

Once your commit pushed, the issue 18 is closed by itself.

kilikkuo commented 7 years ago

Awesome ! Learned : )