Closed enrilizaga closed 1 year ago
Hey @enrilizaga, sorry this takes a while on our side... but the code looks great! Some optional point would be awesome
RELEASE_NOTES.rst
) - just follow the pattern you see there.tests/test_preparation_and_conversion.py
, have a look at https://github.com/PyPSA/atlite/pull/220/filesWould that be possible for you?
Hi @FabianHofmann, many thanks for your reply! I have:
[x] added notebook example solarpv_tracking_options.ipynb and corresponding .nblink
[x] added pv_tracking_test function within test_preparation_and_conversion.py
[x] added tracking option for trigon_model "simple" within tiltedirradiation function
[x] added new version 0.2.10 in the RELEASE_NOTES.rst
Please let me know. Thank you!
This is awesome. I'm having a look at the changes next week.
Ping! Would be super cool to include it in the upcoming PyPSA-Eur version.
closes #140 closes #220
@FabianHofmann @fneum thanks for your comments. Just included them in the last commit. Please let me know!
Hey @enrilizaga, do you have concrete plans on continuing on this PR? Otherwise, we could look whether we can find someone to finish it up.
I know that @Parisra is working on implementing the horizontal tracking option. Mainly obtaining the tilt and orientation of the solar panels using Eq. 8-10 from NREL report Maybe @FabianHofmann you can accept @enrilizaga PR and @Parisra takes it from there
I think that’d make sense. No need for full tracking implemented until merging.
@martavp let's do it :) @Parisra could you then make sure to counter test the formulas? I haven't had the time to go into them in detail.
@enrilizaga many thanks again! This is a great contribution and super well done!
Hi @FabianHofmann , yes I can do that. I've just finished adding the formulas for horizontal tracking and will be doing some tests next week to make sure the results make sense. I'll do a pull request once everything is ready.
great thanks @Parisra
Change proposed in this Pull Request
Added 1-axis vertical and 2-axis tracking option for solar pv (+ small documentation addition for get_windturbineconfig)
Description
Updated orientation.py and convert.py:
Motivation and Context
This change adds the solar pv tracking capability to the code. Solar pv tracking is widely used as it increases the solar pv efficiency significantly. This change improves the fidelity of the code to represent those efficiencies
How Has This Been Tested?
The updated code was tested locally (see snapshots)
The following commands provided the same results (tracking = 0 default) cap_factors_pv_notrack = cutout.pv(panel='CSi', orientation={'slope': 30., 'azimuth': 180.}, capacity_factor=True) cap_factors_pv_0axis = cutout.pv(panel='CSi', orientation={'slope': 30., 'azimuth': 180.}, tracking=0, capacity_factor=True)
![0tracking_comparison_2](https://user-images.githubusercontent.com/94380837/190222623-05199507-16b0-4f4d-903b-07e5d8388a57.PNG)
Tracking = 1 and =2 were tested as well: cap_factors_pv_1axis = cutout.pv(panel='CSi', orientation={'slope': 30., 'azimuth': 180.}, tracking=1, capacity_factor=True) cap_factors_pv_2axis = cutout.pv(panel='CSi', orientation={'slope': 30., 'azimuth': 180.}, tracking=2, capacity_factor=True)
![2tracking](https://user-images.githubusercontent.com/94380837/190222627-60903bfb-6b6a-4849-95c6-1566b193dead.PNG)
Checked that csp was not affected (tracking change only for solar pv) cf = cutout.csp(installation="SAM_solar_tower", capacity_factor=True) cf = cutout.csp(installation="SAM_parabolic_trough", capacity_factor=True)![csp](https://user-images.githubusercontent.com/94380837/190223635-2bfaafe3-5ce4-4949-a778-189f0707686d.PNG)
Type of change
Checklist
pytest
inside the repository and no unexpected problems came up.doc/
.environment.yaml
file.doc/release_notes.rst
.pre-commit run --all
to lint/format/check my contribution