PyPSA / atlite

Atlite: A Lightweight Python Package for Calculating Renewable Power Potentials and Time Series
https://atlite.readthedocs.io
255 stars 87 forks source link

solar pv tracking option added #255

Closed enrilizaga closed 1 year ago

enrilizaga commented 1 year ago

Change proposed in this Pull Request

Added 1-axis vertical and 2-axis tracking option for solar pv (+ small documentation addition for get_windturbineconfig)

Description

Updated orientation.py and convert.py:

Motivation and Context

This change adds the solar pv tracking capability to the code. Solar pv tracking is widely used as it increases the solar pv efficiency significantly. This change improves the fidelity of the code to represent those efficiencies

How Has This Been Tested?

The updated code was tested locally (see snapshots)

Type of change

Checklist

FabianHofmann commented 1 year ago

Hey @enrilizaga, sorry this takes a while on our side... but the code looks great! Some optional point would be awesome

Would that be possible for you?

enrilizaga commented 1 year ago

Hi @FabianHofmann, many thanks for your reply! I have:

Please let me know. Thank you!

FabianHofmann commented 1 year ago

This is awesome. I'm having a look at the changes next week.

fneum commented 1 year ago

Ping! Would be super cool to include it in the upcoming PyPSA-Eur version.

fneum commented 1 year ago

closes #140 closes #220

enrilizaga commented 1 year ago

@FabianHofmann @fneum thanks for your comments. Just included them in the last commit. Please let me know!

FabianHofmann commented 1 year ago

Hey @enrilizaga, do you have concrete plans on continuing on this PR? Otherwise, we could look whether we can find someone to finish it up.

martavp commented 1 year ago

I know that @Parisra is working on implementing the horizontal tracking option. Mainly obtaining the tilt and orientation of the solar panels using Eq. 8-10 from NREL report Maybe @FabianHofmann you can accept @enrilizaga PR and @Parisra takes it from there

fneum commented 1 year ago

I think that’d make sense. No need for full tracking implemented until merging.

FabianHofmann commented 1 year ago

@martavp let's do it :) @Parisra could you then make sure to counter test the formulas? I haven't had the time to go into them in detail.

@enrilizaga many thanks again! This is a great contribution and super well done!

Parisra commented 1 year ago

Hi @FabianHofmann , yes I can do that. I've just finished adding the formulas for horizontal tracking and will be doing some tests next week to make sure the results make sense. I'll do a pull request once everything is ready.

FabianHofmann commented 1 year ago

great thanks @Parisra