Closed dannyopts closed 9 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
7e76a67
) 89.22% compared to head (dc7c996
) 89.25%. Report is 5 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Does the fact coverage has gone down mean we cant merge this PR?
It seems to me this is not a change that would require a test, but if it would normally be accompanied by a test, can someone give me a steer what that would look like?
Thanks @dannyopts, the diffs are a bit hard to read. But it seems you intended the block which was not in the with block, is that right? I would not worry about the code coverage of the patch.
@FabianHofmann yes exactly, we dont exit the stack until after we have read the solution so the gurobi env is not destroyed.
great, thanks!
Currently the Gurobi env is closed before the solution has been retrieved and this can result in an exception being thrown based on a race condition (described in the issue referenced below)
Fixes https://github.com/PyPSA/linopy/issues/192