Closed afuetterer closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.12%. Comparing base (
2883ef9
) to head (93e268e
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Two questions.
Regarding gh-release workflow:
Regarding deploy workflow:
thanks for the PR and raising the issue @afuetterer, I think @lkstrp knows :)
Example of "baipp" workflow: https://github.com/hynek/structlog/blob/main/.github/workflows/ci.yml
Example output: https://github.com/hynek/build-and-inspect-python-package/actions/runs/9817023209
In my opinion this line is redundant, because the workflow only runs, when a tag is pushed:
Yes, it's redundant.
Is this intended? Or should deploy run on tag only?
And this is not intended either. We can also combine both workflows, as done in PyPSA.
And using build-and-inspect-python-package is also good I think. We could also then go further from there. E.g. uploading all commits to test-pypi (as done here) or the version matrix based on package metadata. But this is not urgent.
What does that mean for this PR?
@afuetterer ready to merge?
@afuetterer ready to merge?
Yes. Will open another PR soon.
great thanks @afuetterer
See: https://github.com/PyPSA/PyPSA/pull/954