PyPSA / linopy

Linear optimization with N-D labeled arrays in Python
https://linopy.readthedocs.io
MIT License
155 stars 43 forks source link

ci: overhaul ci and cd workflows #326

Closed afuetterer closed 1 week ago

afuetterer commented 2 weeks ago

Fixes #325

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.95%. Comparing base (1ea4032) to head (c6564a8). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #326 +/- ## ========================================== + Coverage 84.93% 85.95% +1.02% ========================================== Files 17 17 Lines 4202 4202 Branches 988 988 ========================================== + Hits 3569 3612 +43 + Misses 474 431 -43 Partials 159 159 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lkstrp commented 2 weeks ago

If you don't mind, I would just add some changes

afuetterer commented 2 weeks ago

If you don't mind, I would just add some changes

Of course, go ahead.

afuetterer commented 2 weeks ago

Plesse see the output of baipp:

https://github.com/PyPSA/linopy/actions/runs/9871896061/attempts/1#summary-27260815050

I think this is really helpful.

lkstrp commented 2 weeks ago

@afuetterer This is all super great. Thanks a lot for your input ! I made some smaller adjustments and added trusted publishing and tried to use the baipp dist also for tests. Would you have a look?

CI with the baipp versions still needs a fix.

afuetterer commented 2 weeks ago

CI with the baipp versions still needs a fix.

What do you mean?

afuetterer commented 2 weeks ago

I added concurrency to cancel early, if multiple commits are pushed in short time to the same PR.

afuetterer commented 2 weeks ago

Okay, well, of course you needed to have python versions defined in the pyproject.toml. :smile:

afuetterer commented 2 weeks ago

Oh my god, finally. Please squash. :smile:

afuetterer commented 2 weeks ago

Should I squash the commits or do you perform squash and merge?

Any more changes at the moment?

afuetterer commented 2 weeks ago

I guess you need to update the required check in your PR settings. It hangs.

afuetterer commented 2 weeks ago

Also the badge URL in the readme needs to be changed.

afuetterer commented 2 weeks ago

Fingers crossed, that the release workflow and the trusted publishing works.

lkstrp commented 2 weeks ago

Fingers crossed, that the release workflow and the trusted publishing works.

I will test that in a release of a different repo soon

FabianHofmann commented 1 week ago

@lkstrp let me know if we should merge this

lkstrp commented 1 week ago

@FabianHofmann Let's go

afuetterer commented 1 week ago

Oh no. You did not squash the commits, instead you merged my messy 20+ testing commits.

FabianHofmann commented 1 week ago

ah damn forgot about that, a good reminder that we wanted to set squash as default for prs

afuetterer commented 1 week ago

Good idea. Now you have my, try, try, finally commit messages in your history. :)

FabianHofmann commented 1 week ago

so that everybody these sees that effort you have made ;) thanks for the nice contributions!