Closed afuetterer closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.95%. Comparing base (
1ea4032
) to head (c6564a8
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If you don't mind, I would just add some changes
If you don't mind, I would just add some changes
Of course, go ahead.
Plesse see the output of baipp:
https://github.com/PyPSA/linopy/actions/runs/9871896061/attempts/1#summary-27260815050
I think this is really helpful.
@afuetterer This is all super great. Thanks a lot for your input ! I made some smaller adjustments and added trusted publishing and tried to use the baipp dist also for tests. Would you have a look?
CI with the baipp versions still needs a fix.
CI with the baipp versions still needs a fix.
What do you mean?
I added concurrency to cancel early, if multiple commits are pushed in short time to the same PR.
Okay, well, of course you needed to have python versions defined in the pyproject.toml. :smile:
Oh my god, finally. Please squash. :smile:
Should I squash the commits or do you perform squash and merge?
Any more changes at the moment?
I guess you need to update the required check in your PR settings. It hangs.
Also the badge URL in the readme needs to be changed.
Fingers crossed, that the release workflow and the trusted publishing works.
Fingers crossed, that the release workflow and the trusted publishing works.
I will test that in a release of a different repo soon
@lkstrp let me know if we should merge this
@FabianHofmann Let's go
Oh no. You did not squash the commits, instead you merged my messy 20+ testing commits.
ah damn forgot about that, a good reminder that we wanted to set squash as default for prs
Good idea. Now you have my, try, try, finally commit messages in your history. :)
so that everybody these sees that effort you have made ;) thanks for the nice contributions!
Fixes #325