PyPSA / pypsa-ariadne

High resolution, sector-coupled model of the German Energy System
https://ariadneprojekt.de/en/model-documentation-pypsa/
MIT License
15 stars 6 forks source link

Fix capacity constraints for post discretization #215

Closed toniseibold closed 1 month ago

toniseibold commented 1 month ago

With the post discretization the capacity constraints were not active for the second optimization since they already existed in n.globalconstraints but are not present in n.model.

Validation Balance Scenario image

Validation Current Policies Scenario image

Before asking for a review for this PR make sure to complete the following checklist:

github-actions[bot] commented 1 month ago

Validator Report

I am the Validator. Download all artifacts here. I'll be back and edit this comment for each new commit.

Ariadne Variables

Comparison
NRMSE Pearson
Capacity|Electricity|Storage Converter 0.505 0.428
Capacity|Electricity|Gas|OC 0.408 0.293
Secondary Energy|Electricity|Hydro 0.405 0.275
Price|Secondary Energy|Gases|Hydrogen 0.397 0.000
Price|Secondary Energy|Liquids|Hydrogen 0.279 0.000
Investment|Energy Supply|Electricity|Transmission|Offwind-AC 0.243 1.000
Investment|Energy Supply|Electricity|Transmission|AC 0.199 0.846
Carbon Sequestration|DACCS 0.143 1.000
NRMSE: Normalized (combined-min-max) Root Mean Square Error Pearson: Pearson correlation coefficient Threshold: NRMSE > 0.1 Only variables reaching the threshold are shown. Find the equivalent plot for all of them below.
Plots
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
csvs/price_statistics.csv :warning:Changed 0.002 0.29
csvs/cumulative_cost.csv :warning:Changed 0.000 0.11
csvs/metrics.csv :warning:Changed 0.000 0.13
csvs/curtailment.csv :warning:Changed 0.000 0.06
csvs/nodal_cfs.csv :warning: NaN mismatch
csvs/nodal_costs.csv :warning: NaN mismatch
csvs/nodal_capacities.csv :warning: NaN mismatch
csvs/nodal_supply_energy.csv :warning: NaN mismatch
csvs/costs.csv :white_check_mark: Almost equal 0.000 0.01
csvs/cfs.csv :white_check_mark: Almost equal 0.039 0.00
csvs/supply.csv :white_check_mark: Almost equal 0.001 0.00
csvs/capacities.csv :white_check_mark: Almost equal 0.000 0.00
csvs/energy.csv :white_check_mark: Almost equal 0.000 0.01
csvs/supply_energy.csv :white_check_mark: Almost equal 0.000 0.03
csvs/prices.csv :white_check_mark: Almost equal 0.027 0.00
csvs/market_values.csv :white_check_mark: Almost equal 0.007 0.05
csvs/weighted_prices.csv :white_check_mark: Equal
NRMSE: Normalized (combined-min-max) Root Mean Square Error MAE (norm): Mean Absolute Error on normalized data (min-max) Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing fix_disc_constraints (778c2d5) with main (99f2c86). Branch is 5 commits ahead and 3 commits behind. Last updated on 2024-10-02 19:14:56 CEST.