PyPSA / pypsa-eur

PyPSA-Eur: A Sector-Coupled Open Optimisation Model of the European Energy System
https://pypsa-eur.readthedocs.io/
326 stars 227 forks source link

remove `data/hydro_capacities.csv` with untraceable source #1279

Open fneum opened 2 weeks ago

fneum commented 2 weeks ago

This is kind of a step backward as it uses crude fill values, but I am skeptical regarding the data file that is currently being used.

Distribution of storage durations (h) in powerplantmatching

image

koen-vg commented 2 weeks ago

I guess your digging for the source also ended around here? image I had a brief look at the two cited publications but in a few minutes I couldn't find the promised hydro numbers.

I quickly checked the numbers for the three countries with the largest reservoir capacities (Norway, Sweden, Spain), and they seem to be very accurate, however. (Just looking at E_store[TWh].) Did you check different countries for which the results were clearly wrong?

I think this PR is reasonable if we know that we want to throw this unexplainable file out. But it would be a shame if that happened to significantly worsen the data quality for the largest hydro countries. What's the difference, more or less?

On the other hand we all know that hydro is notoriously difficult; even with the correct storage capacities we don't automatically get correct results anyway, and lowering reservoir capacities might actually make the final results more accurate since the model tends to use reservoir capacities more aggressively than is realistic.

fneum commented 2 weeks ago

Thanks @koen-vg, @lisazeyen and I decided to put this on hold for the moment.

The motivation was indeed to remove data without a source.

We have asked some more hydro-experts we know, whether they can help.

fneum commented 1 week ago

Potential alternative source: https://www.mdpi.com/1996-1073/10/11/1841

image