PyPSA / pypsa-eur

PyPSA-Eur: A Sector-Coupled Open Optimisation Model of the European Energy System
https://pypsa-eur.readthedocs.io/
338 stars 239 forks source link

Regression in #519a4f2: Adding `p_max_pu` for `conventional_carriers` through `.csv` file #723

Open euronion opened 1 year ago

euronion commented 1 year ago

Checklist

Describe the Bug

(currently migrating from version 0.8.0 to current master)

With commit #591a4f2 and specifically here

https://github.com/PyPSA/pypsa-eur/blob/d7554bccffd02933cbe2c9d129b7ae006645add6/rules/build_electricity.smk#L331-L342

providing a filename to a data/*.csv file in the config like

https://github.com/PyPSA/pypsa-eur/blob/d7554bccffd02933cbe2c9d129b7ae006645add6/config/config.default.yaml#L228-L229

only works if the conventional_carrier is also specified here:

https://github.com/PyPSA/pypsa-eur/blob/d7554bccffd02933cbe2c9d129b7ae006645add6/config/config.default.yaml#L113

but that also causes existing powerplants to be included.

Before it was possible to not have existing powerplants included but allow for e.g. conventional power plants via

https://github.com/PyPSA/pypsa-eur/blob/d7554bccffd02933cbe2c9d129b7ae006645add6/config/config.default.yaml#L105

to have those types extendable and put in p_max_pu via the config line above linking to data/*.csv files.

Not sure if that was intentionally changed, but it seems like it is now no longer possible to have p_max_pu through .csv file + no existing powerplant capacities + extendable powerplant capacities via config.

Error Message

-

(weird failures, because the filename is added as p_max_pu instead of the values.

fneum commented 1 year ago

I had a similar issue where it was not possible to add wind and solar without existing capacity anymore.