search

PyPSA / pypsa-usa

PyPSA-USA: An Open-Source Energy System Optimization Model for the United States
https://pypsa-usa.readthedocs.io
MIT License
58 stars 23 forks source link

Existing Battery Storage not assigned Energy Capacity Naming #198

Open ktehranchi opened 8 months ago

ktehranchi commented 8 months ago

Checklist

The Issue

As shown in #197 Battery storage is separated from xhr battery storage items. This is caused by existing batteries being added from EIA data which doesn't name the types of batteries explicitly. We can assign the Xhours of storage to the name when adding it in add_electricity

Steps To Reproduce

No response

Expected Behavior

No response

Error Message

No response

Anything else?

No response

trevorb1 commented 8 months ago

Is there a reason not to just group all batteries together? (Just my experience for my research questions, but) I have not had a use case where in dispatch results I need to see different amount of battery capacity. Instead, I have been more concerned with seasonal vs. daily storage charging/discharging. I guess 10hr could be close to seeing as longer-term load shifting, but not really seasonal storage.

However this may have just been my use cases! Im def not saying this is an overarching rule! And I am not saying one way is better than another, just a thought to simplify plotting! :)

Or maybe this is just a configuration option in the future at some point.

ktehranchi commented 8 months ago

I think this make sense... ill group them together!

ktehranchi commented 5 months ago

@trevorb1 I looked into do thing this, but noticed many of the storage devices don't fit into nice integer level storage buckets. For example, some where ~0.34 or 2.5 hour BESS.

I would vote for keeping these separated in the model and results so we know what is already existing and we don't mis-classify. If we wanted to round to nearest integer we would also end up with many buckets.

If you are cool with this we can close the ticket.

trevorb1 commented 5 months ago

@ktehranchi Im totally fine with keeping storage separate, if they dont group together nicely!

To clarify, though, you are proposing for each different duration storage we create a new storage component? If there are a bunch, solve times can quickly shoot up due to the storage constraints being kinda heavy? I wonder if we should just bin them into like 2hr, 4hr, 8hr storage or similar? Or if there are only a few storage options, maybe this isnt needed?

ktehranchi commented 5 months ago

hmmm I guess I was thinking we would keep all the existing storage as 'Battery Storage'.... these would then get lumped together. But I think you're right that we should catagorize them into 1 hour, 2 hour, X hour storage if they fit well. Otherwise we'll leave them as Battery storage?

I'm just thinking, what would we put for the plants that are <0.5 hour storage?