search

PyProphet / pyprophet

PyProphet: Semi-supervised learning and scoring of OpenSWATH results.
http://www.openswath.org
BSD 3-Clause "New" or "Revised" License
29 stars 21 forks source link

Py3 support #6

Closed bretttully closed 6 years ago

bretttully commented 7 years ago

Just wondering if there is any plans for py3 support? I've just run a 2to3 conversion and many tests pass, but many fail due to str/byte comparison issues.

Cheers

hroest commented 7 years ago

we are happy to talk PR but the whole handling of strings is really annoying in Python3, especially when having a C++ part, so we havent put in the work yet to do it.

grosenberger commented 6 years ago

The new SQLite-enabled PyProphet implementation is compatible with Python 3: http://openswath.org/en/latest/docs/sqlite.html