PyProphet / pyprophet

PyProphet: Semi-supervised learning and scoring of OpenSWATH results.
http://www.openswath.org
BSD 3-Clause "New" or "Revised" License
29 stars 21 forks source link

ImportError: cannot import name 'factorial' #70

Closed fangfeiz closed 3 years ago

fangfeiz commented 5 years ago

Traceback (most recent call last): File "~/anaconda3/bin/pyprophet", line 6, in from pyprophet.main import cli File "~/anaconda3/lib/python3.6/site-packages/pyprophet/main.py", line 6, in from .runner import PyProphetLearner, PyProphetWeightApplier File "~/anaconda3/lib/python3.6/site-packages/pyprophet/runner.py", line 12, in from .pyprophet import PyProphet File "~/anaconda3/lib/python3.6/site-packages/pyprophet/pyprophet.py", line 11, in from .stats import (lookup_values_from_error_table, error_statistics, File "/home/daishaozheng_beihang/anaconda3/lib/python3.6/site-packages/pyprophet/stats.py", line 14, in from statsmodels.nonparametric.kde import KDEUnivariate File "~/anaconda3/lib/python3.6/site-packages/statsmodels/nonparametric/kde.py", line 21, in from statsmodels.sandbox.nonparametric import kernels File ".~/anaconda3/lib/python3.6/site-packages/statsmodels/sandbox/nonparametric/kernels.py", line 24, in from scipy.misc import factorial ImportError: cannot import name 'factorial'

pyprophet seems not compatible with scipy version 1.3.1. If scipy downgrades to 1.2.1, pyprophet works. The location of factorial in the scipy 1.3.1 now is: from scipy.special import factorial. Do you consider upgrade your code that is compatible with newer version or we'd better setup a conda environment for the scipy 1.2?