search

PySCeS / pysces

The official PySCeS project source code repository.
https://pysces.github.io
Other
34 stars 10 forks source link

If and else clause have same code PyscesSED.py #18

Closed matthiaskoenig closed 7 years ago

matthiaskoenig commented 8 years ago

Hi Bret, just looked over the PyscesSED.py file and the following does not make sense. The best M

    def addModel(self, id, model):
        try:
            if not self.models.has_key(id):
                self.models[id] = model.clone()
            else:
                self.models[id] = model.clone()
bgoli commented 8 years ago

Thanks will look into it, I mostly work with a single model so missed this one.

matthiaskoenig commented 8 years ago

Not really using it, just read over the code and caught my attention. M

On Feb 24, 2016 2:39 PM, "Brett Olivier" notifications@github.com wrote:

Thanks will look into it, I mostly work with a single model so missed this one.

— Reply to this email directly or view it on GitHub https://github.com/PySCeS/pysces/issues/18#issuecomment-188258452.

bgoli commented 7 years ago

fixed.