search

PySCeS / pysces

The official PySCeS project source code repository.
https://pysces.github.io
Other
34 stars 10 forks source link

Default user directory location on Windows #35

Closed jmrohwer closed 4 years ago

jmrohwer commented 4 years ago

Move the default Pysces folder on win32 to %USERPROFILE%\Pysces (e.g. C:\Users\<username>\Pysces) instead of %HOMEDRIVE%\Pysces (e.g. C:\Pysces).

To ensure backward compatibility with legacy installations, upon package import the old location is first checked, and if the configuration file is present there, it is used so that the program functions as previously. Only when C:\Pysces is not found, a new user directory is created at C:\Users\<username>\Pysces.

This change makes sense to bring the Windows and Unix versions more in line with each other, and in addition the current default setup does allow not concurrent use by two different users on a Windows box. In addition "contaminating" the root of the system drive with user folders is not really elegant :grin:

This will have to be documented, I have not done so yet but can edit the docs once this pull request is accepted and merged.

jmrohwer commented 4 years ago

@bgoli bump on this?

I see you've added some commits to master and also bumped up the version to 0.9.8.

I'd like to build a new set of wheels. With a fresh install (where the user directory is not present) using 0.9.7 under Python 3, it is currently totally broken due to the string handling (see my commits to master that fix this). So we should actually do a new release.

If you agree with this PR it would be great to include it, it can be merged into master.

So at what point can we bump up to 1.0.0?

bgoli commented 4 years ago

Great stuff, I think we should do an 0.9.8 now and then see if there are any key features that would be good for a a 1.0 release, e.g., maybe SBML L3 support, a new CVODE interface etc.

Just a note on compiling for Windows, when using the new numpy/f2py with Visual Studio. I needed to use a newer GCC for gfortran and not the one supplied with anaconda (4.7 or something ancient). In the end I used gcc 8.1 to get it to work. Between Jannie and myself we have a recipe for Windows builds that seems to work pretty well I'll post it somewhere here.