PySCeS / pysces

The official PySCeS project source code repository.
https://pysces.github.io
Other
34 stars 10 forks source link

Don't change CWD on startup #42

Closed jmrohwer closed 3 years ago

jmrohwer commented 3 years ago

As per #39 changing the current working directory is an unexpected side effect that largely stems from legacy PySCeS code at a time when the HOME environment variable was not properly defined under Windows.

This PR introduces a new configuration option change_dir_on_start = False in pyscfg.ini as well as .pys_usercfg.ini. The default installation option is False but can be set to True in user configuration. When False, the current working directory is maintained upon importing pysces and loading a model. When set to True, the previous behaviour results, i.e. change directory to $HOME/Pysces after importing pysces and loading a model.

Note that the option to set the model directory and output directory to the current working directory still exists in .pys_usercfg.ini, as it has for some time already. This is for keeping PSC files in a folder related to a particular project and not in a central folder, by setting the options as follows:

model_dir = ./
output_dir = ./