search

PySCeS / pysces

The official PySCeS project source code repository.
https://pysces.github.io
Other
34 stars 10 forks source link

update PLY and check other support libraries #55

Closed bgoli closed 2 years ago

bgoli commented 3 years ago

Reminder that I should update PLY in lib and core2

bgoli commented 3 years ago

Turns out we are using the last legacy release 3.11 and eagerly await PLY 4.0 (https://github.com/dabeaz/ply)

jmrohwer commented 3 years ago

Incidentally, why don't we include this as a dependency, why are you manually copying the files? (Was wondering about that previously).

bgoli commented 3 years ago

There are issues with imports and I like having a static version that works. Also in general would rather reduce module dependencies.

jmrohwer commented 3 years ago

That's a good point, only thing is you then manually have to keep checking for updates. But if the static version works for your purposes then that's good enough I guess.

bgoli commented 3 years ago

PLY is stable and rarely updated so I only need to check every few years