PySCeS / pysces

The official PySCeS project source code repository.
https://pysces.github.io
Other
34 stars 10 forks source link

Some species (species not involved in rate equations?) aren't recorded #57

Closed jonrkarr closed 2 years ago

jonrkarr commented 3 years ago

Since there doesn't appear to be a way to record the values of non-constant parameters (e.g., needed for some plots in BioModels), I tried to see if I could use an assignment rule to record the values of non-constant parameters (i.e., assign the value of a parameter to a species).

Example: dNFAT (parameter) and dNFAT_species (species) in BIOMD678.xml.txt.

However, PySCeS didn't record the value of dNFAT_species. One possible hint I see is

Info: "dNFAT_species" has been initialised but does not occur in a rate equation

I have two questions:

jmrohwer commented 2 years ago

This has now been fixed in Release 1.0.2. Assignment rules are tracked by default in a simulation with CVODE, and the values are available via mod.data_sim.getXData(). Refer to https://pyscesdocs.readthedocs.io/en/latest/userguide_doc.html#simulation-results

The change was implemented in https://github.com/PySCeS/pysces/pull/77/commits/8ebbcb326d205e5818e4a7a350eb645c11d83c0e with additional fixes in https://github.com/PySCeS/pysces/pull/77/commits/e9c4444ae2b525cfb32c1e0192eea4b3e20577fd.