search

PySCeS / pysces

The official PySCeS project source code repository.
https://pysces.github.io
Other
34 stars 10 forks source link

Bug fix release #73

Closed jmrohwer closed 2 years ago

jmrohwer commented 2 years ago

I've fixed some bugs, nothing major but for some projects I need a release with these fixes. Okay if I merge this and release 1.0.1?

jmrohwer commented 2 years ago

Okay I can put it back for the wheels. For Anaconda, it was out for 1.0.0 already but there it's easier to upgrade the Python. I just think providing wheels for 5 Python versions and 3 platforms is really pushing it... :raised_eyebrow: But no harm done. Are you otherwise okay with the PR?

bgoli commented 2 years ago

Blame Python's insane release schedule for the all the versions :-) I've just got back from vacation so will look at the rest over the next day or so

jmrohwer commented 2 years ago

This has to do with the version.py change commit 01fc890

The historical reason for this is that core2 can be used independently from PySCeS but this is okay to change now. I don't really like setup.py automatically executing code, what about specifying the version as the first line in a text file (version.txt) and then reading that in as the version number instead. This could potentially be useful outside of Python as well.

Fixed in 6eb7b19

jmrohwer commented 2 years ago

Is it possible to leave 3.6 support in (there may be users using older Linux versions) or does it break the build process? If it does, please ignore.

Fixed in bc869b0

jmrohwer commented 2 years ago

+1 (i just committed adding version.txt to manifest.in)

And I added version.txt to mydata_files in setup.py (otherwise it doesn't get installed)

jmrohwer commented 2 years ago

@bgoli are you okay with the other commits? They are really just bug fixes.