Need the favicon back

[kimo]

Hi @laffra ,

This is Krishna here. Unable to run pysheets (on Intel Mac) unless I manually add the ltk folder into the static folder of the project. Sangram is also facing the same problem. It may be because I am new to the python build process. Please advise.

cd <<pysheets>>
cp -r .venv/lib/python3.12/site-packages/ltk src/static

Above steps got the project going without errors. Otherwise, i was getting 404's for all **static/ltk/*** files in the below list from the initial landing page.

<mpy-config>
    interpreter = ""

    [files]

"static/constants.py" = "constants.py"
"static/menu.py" = "menu.py"
"static/state.py" = "state.py"
"static/pysheets.py" = "pysheets.py"
"static/timeline.py" = "timeline.py"
"static/editor.py" = "editor.py"
"static/api.py" = "api.py"
"static/lsp.py" = "lsp.py"
"static/preview.py" = "preview.py"
"static/inventory.py" = "inventory.py"
"static/models.py" = "models.py"
"static/selection.py" = "selection.py"
"static/storage.py" = "storage.py"
"static/history.py" = "history.py"
"static/html_maker.py" = "html_maker.py"
"static/views/spreadsheet.py" = "views/spreadsheet.py"
"static/views/cell.py" = "views/cell.py"

**_

"static/ltk/jquery.py" = "ltk/jquery.py" "static/ltk/widgets.py" = "ltk/widgets.py" "static/ltk/pubsub.py" = "ltk/pubsub.py" "static/ltk/init.py" = "ltk/init.py" "static/ltk/logger.py" = "ltk/logger.py" "static/ltk/ltk.js" = "ltk/ltk.js" "static/ltk/ltk.css" = "ltk/ltk.css"

_**

</mpy-config>

[kimo]

@kssd fyi.

@sangramsingh-kss

[laffra]

I just noticed that LTK was missing from the MANIFEST.in file, which PyPI uses to bundle up a release. I updated the MANIFEST to include LTK and hosted js/css files. Starting with version 0.2.11, LTK should be included as expected. This has been tested locally by first running pip install pysheets-app --upgrade and then running pysheets.

[kimo]

Thank you.

Btw, favicon may have been lost in the latest push.

[2024-09-28 17:43:24,736] ERROR in pysheets: 404: /favicon.ico
127.0.0.1 - - [28/Sep/2024 17:43:24] "GET /favicon.ico HTTP/1.1" 200 -
[2024-09-28 17:43:25,679] ERROR in pysheets: 404: /favicon.ico
127.0.0.1 - - [28/Sep/2024 17:43:25] "GET /favicon.ico HTTP/1.1" 200 -

[laffra]

I will add the favicon to the manifest as well.

On Sun, Sep 29, 2024, 2:43 AM Krishna Guda @.***> wrote:

Thank you. But we seem to have lost the favicon which is probably not a big deal. But this is what I am getting now.

python code

import networkx as nx

graph = nx.DiGraph()

graph.add_edges_from([("root", "a"), ("a", "b"), ("a", "e"), ("b", "c"), ("b", "d"), ("d", "e")])

graph

Screenshot

Screenshot.2024-09-28.at.5.39.38.PM.png (view on web) https://github.com/user-attachments/assets/82ac1397-fc72-469f-ab8b-69035ce621b0

— Reply to this email directly, view it on GitHub https://github.com/PySheets/pysheets/issues/83#issuecomment-2381040239, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4XAKADAIAUT26TWDTS4ITZY5EJNAVCNFSM6AAAAABPADQZFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGA2DAMRTHE . You are receiving this because you were mentioned.Message ID: @.***>

[kimo]

LTK is solved. verified in 3.0.13. We need the favicon back :)

[kimo]

Fixed in v0.3.17