Closed ssweber closed 1 year ago
There's a bug when you close the quick-editor, all the foreign-key descriptions disappear. trying to figure it out.
Took a second to figure out what was happening!
When quick_editor was opened, its Form init called auto_add_relationships, duplicating Relationship instances… exposing my bug in table_values that allowed the same column to be processed twice.
Thanks! This will help a lot! I'll review now and hopefully get it merged in finally! Again, sorry for the delay. Getting stuck with all that work put me behind on literally everything, so the few days I had off were spent catching up yard work, projects around the house and family time. Unfortunately all of that too was from the moment I woke up until bed time. I really appreciate all of your patience!
On Tue, May 30, 2023 at 9:39 AM ssweber @.***> wrote:
@PySimpleSQL https://github.com/PySimpleSQL Hope this is a little easier to look through!
You can view, comment on, or merge this pull request online at:
https://github.com/PySimpleSQL/pysimplesql/pull/321 Commit Summary
- 6c23011 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/6c23011406ea42473c275503786858ee4b98158f imports
- 6a8a6d6 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/6a8a6d665d02c82e0121270b56a1c357eb855cd2 constants and pk_placeholder
- cfa19cd https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/cfa19cd9e5b4dde25d91160c811f44a8b9e0fe88 change row_is_virtual to pk_is_virtual
- c188cd9 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/c188cd99eba6b5bb5d3ffd55e9b06324c14d8c9a date -> dt.date cleanup, work on casting
- 0febf76 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/0febf76bbe43db96fb4e96fee7de04902e624e54 Move langformat underneith languagepack
- 0929a80 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/0929a80ba25e97213d51a003d2c2c0d8338d96aa Add generated row handling
- 90f1609 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/90f1609039ec1a91c85e9b559435b581ed6e9e88 cast table_val in value_changed
- 325c33a https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/325c33a5b32dece29c9f45e684fcbb17560b6f6c Use widget.see instead of scrolling to pk-position
- ac3c8ca https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/ac3c8caf9543abb8bef25f239664504a9064b2f5 Introduce and use new enhanced widgets
- 06a9579 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/06a957907fdee6c2abb63c2a83f042504aac82f9 Updates to _CellEdit ane _LiveUpdate
- 77e0286 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/77e0286e1d32e25fc833a231daf4e1114dce4f03 isinstance cleanup / combobox handling / sg.text handling / lazytable support /
- ddf2361 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/ddf23616dab139a4943966db446fc51596ca6e05 Rewritten search
- 1c31f40 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/1c31f4047783540cbb53714a829476285a7b806e try/except in set_by_pk
- 5c1ba04 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/5c1ba04f3a6a99a86a2b6e2f379e2f73deef21cc small fix for get_current_row
- b002f86 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/b002f86628c02b41663280f5ad2d128769d3755a update set_current to write an event
- f558ad8 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/f558ad8a7f988e6e7e28770e031031e1479dfff6 fix for dtype clobbering
- 053f7a3 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/053f7a3f75b37b51fbad0f1fcb0253527f9febfb use themepack icon in all windows
- 3b25095 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/3b25095ff182cc51619728a2760e9bb9eb30cb4d Modernize quick_editor
- c6501ca https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/c6501ca09544abf257979cb034708ce08c9f8d30 Fix for dtype clobbering
- 4c02cf8 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/4c02cf8f372da2ac7d1d38146971f976b565573a Update tableheadings to allow save. Change callbackwrapper name
- ff80955 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/ff80955cf9fd561e69fcaa5f41e9beb0bc2a3fc9 add items to checkbox_to_bool
- 8d9fe87 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/8d9fe878efbef622f5f72279f77459974bb4f0b3 small fix for backup row
- 2ac8d21 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/2ac8d21db38ddd5b300d62dc9030cee4201c86e0 rewritten table_values
- 690f0f1 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/690f0f13348196f9acbcdeab738adede438e9bdb rewritten combobox_values
- b1ee5d7 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/b1ee5d7710ba64e508665d1ec11d813ace144794 preventative fix for closing a None popup
- 121d127 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/121d127687ebfc2dde8302284aae41a19e8d09e1 add placeholders to LanguagePack
- 37e95f1 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/37e95f153e710337a1c115409ff72bb1c1494774 preventative fix for double-button bind
- fb097d1 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/fb097d1705cc4889513d5037e6a1fd46ca81940f Add placeholder to search-box
- 5bdbc59 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/5bdbc597c4c522ca30827e53ec0a1adb73e6e132 revert change, show markers for sg.Text
- 2b90bc6 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/2b90bc6b4d6e4a2bee8284cad87518208ee2ab7a write an event on change in cell_edit
- 95723d9 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/95723d99115c5c82b9fba3a25a0f26ee50532304 Add markers, placeholder, and checkbox info to Themepack
- 037cde3 https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/037cde38e10cac54c8a88550b86f4a7479e12518 small fix (i had manually put this fix in from another branch)
- aea2d9c https://github.com/PySimpleSQL/pysimplesql/pull/321/commits/aea2d9c1670ac8d9f4f6aabdde6c1b31776a4187 New examples - checkbox_behavior and orders
File Changes
(3 files https://github.com/PySimpleSQL/pysimplesql/pull/321/files)
- A examples/SQLite_examples/checkbox_behavior.py https://github.com/PySimpleSQL/pysimplesql/pull/321/files#diff-62d693eb24e00e6f1e7ded5354081f5825dd8edbdceeaad81186827bf78849fa (80)
- A examples/SQLite_examples/orders.py https://github.com/PySimpleSQL/pysimplesql/pull/321/files#diff-cd09e21cc8d65535a7ab30719ad0e043e223def93d5ad18f2202d48549d8e484 (374)
- M pysimplesql/pysimplesql.py https://github.com/PySimpleSQL/pysimplesql/pull/321/files#diff-3ddcdf2a127da41a312fffeb9adb87397d8dbdb0e6dbf7b342e516c50a2165ac (2009)
Patch Links:
- https://github.com/PySimpleSQL/pysimplesql/pull/321.patch
- https://github.com/PySimpleSQL/pysimplesql/pull/321.diff
— Reply to this email directly, view it on GitHub https://github.com/PySimpleSQL/pysimplesql/pull/321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQX2RESKYQEHANVLLQX43C3XIX2C3ANCNFSM6AAAAAAYUBED74 . You are receiving this because you were mentioned.Message ID: @.***>
Thanks for merging! And the encouraging words. I know that was a lot to review.
No worries about any delay; gave me plenty of time to test some more, catch some more bugs, and simplify things.
@PySimpleSQL Hope this is a little easier to look through!