PySimpleSQL / pysimplesql

SQLite3 binding for PySimpleGUI
GNU Lesser General Public License v3.0
47 stars 16 forks source link

Wip #321

Closed ssweber closed 1 year ago

ssweber commented 1 year ago

@PySimpleSQL Hope this is a little easier to look through!

ssweber commented 1 year ago

There's a bug when you close the quick-editor, all the foreign-key descriptions disappear. trying to figure it out.

ssweber commented 1 year ago

Took a second to figure out what was happening!

When quick_editor was opened, its Form init called auto_add_relationships, duplicating Relationship instances… exposing my bug in table_values that allowed the same column to be processed twice.

PySimpleSQL commented 1 year ago

Thanks! This will help a lot! I'll review now and hopefully get it merged in finally! Again, sorry for the delay. Getting stuck with all that work put me behind on literally everything, so the few days I had off were spent catching up yard work, projects around the house and family time. Unfortunately all of that too was from the moment I woke up until bed time. I really appreciate all of your patience!

On Tue, May 30, 2023 at 9:39 AM ssweber @.***> wrote:

@PySimpleSQL https://github.com/PySimpleSQL Hope this is a little easier to look through!

You can view, comment on, or merge this pull request online at:

https://github.com/PySimpleSQL/pysimplesql/pull/321 Commit Summary

File Changes

(3 files https://github.com/PySimpleSQL/pysimplesql/pull/321/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/PySimpleSQL/pysimplesql/pull/321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQX2RESKYQEHANVLLQX43C3XIX2C3ANCNFSM6AAAAAAYUBED74 . You are receiving this because you were mentioned.Message ID: @.***>

ssweber commented 1 year ago

Thanks for merging! And the encouraging words. I know that was a lot to review.

No worries about any delay; gave me plenty of time to test some more, catch some more bugs, and simplify things.