search

PySlither / Slither

A Python module for bridging Scratch and Python
http://pyslither.github.io/
MIT License
14 stars 6 forks source link

Using Codacy? #25

Closed BookOwl closed 8 years ago

BookOwl commented 8 years ago

Codacy is an online code review tool. Basically, it makes sure that we write good, quality code. It is also free for open source projects (like us). Currently, it gives us an A.

Codacy Badge

Should we use it?

Tymewalk commented 8 years ago

How does it detect things like "Unused Code" and "Code Style"?

BookOwl commented 8 years ago

I don't know, but it does a good job. I use it for some of my projects.

Tymewalk commented 8 years ago

All right, it looks good to me! (Now we'll have something to tell us when we've broken the entire thing :stuck_out_tongue:) @Omegabyte, what's your take on this?

ghost commented 8 years ago

Seems good but what does it consider as 'good quality code'?

Tymewalk commented 8 years ago

@BookOwl Why'd you close it?

Tymewalk commented 8 years ago

Bump. I don't remember us reaching any decisions.

Tymewalk commented 8 years ago

Since this is open, I think Codacy is a great idea. I already see a couple places where it says there's code that isn't being used (a couple import pygames where Slither just takes care of that for us, for example).

Tymewalk commented 8 years ago

@Omegabyte I think it considers it based on things like how many TODOs we have, and how much code goes unused.

BookOwl commented 8 years ago

@Tymewalk, do you think we should use it?

Tymewalk commented 8 years ago

@BookOwl Yes. I already see a few things on Codacy that could be fixed before they cause bigger problems later on.

BookOwl commented 8 years ago

OK, I'll put the icon on the README and close this.