PySlither / Slither

A Python module for bridging Scratch and Python
http://pyslither.github.io/
MIT License
14 stars 6 forks source link

Remove set, get, and changeBy functions #34

Closed Tymewalk closed 8 years ago

Tymewalk commented 8 years ago

Removes set, changeBy, and get functions, except for:

For fixing #30.

BookOwl commented 8 years ago

I think that we should keep goTo (but can we please rename it goto?)

Tymewalk commented 8 years ago

@BookOwl Sure.

BookOwl commented 8 years ago

Ok. I just have always seen it spelled that way.

BookOwl commented 8 years ago

Should we remove the get/set functions from Stage?

Tymewalk commented 8 years ago

@BookOwl Which ones?

Tymewalk commented 8 years ago

Oh, never mind, you mean setColor and getCostumeNumber and getCostumeName. Sure, I'll remove those.

The only thing that has to stay is costumes because those get handled specially with a bunch of magic I wrote a couple of weeks ago.

BookOwl commented 8 years ago

Oh, never mind, you mean setColor and getCostumeNumber and getCostumeName. Sure, I'll remove those.

Great!

The only thing that has to stay is costumes because those get handled specially with a bunch of magic I wrote a couple of weeks ago.

We actually could get rid of those by using properties.

Tymewalk commented 8 years ago

We could actually get rid of those by using properties.

OK. But for now, I'm going to merge this to master and make a new pull request for that - I kinda mucked up this branch using the command-line

BookOwl commented 8 years ago

Sounds good to me!