PySloth / pysloth

A Python Package for Probabilistic Prediction
https://pysloth.readthedocs.io/
Apache License 2.0
22 stars 3 forks source link

Discussion Thread on Old Codebase #2

Closed leonarduschen closed 3 years ago

leonarduschen commented 3 years ago

Hi @valeman

I've been reading through your codebase and I figured I will need your clarifications on some part of it, I'll be using this thread to post my questions.

Also, I haven't really read your paper in a thorough manner yet - so I guess I might have been able to figure these out myself when I have done so in the near future.

leonarduschen commented 3 years ago
.
├── CCPD.py
├── CRPS_function.py
├── CRPS.py
├── SCPD.py
└── notebook.ipynb

I noticed CRPS_function is in both CRPS_function.py and SCPD.py. The only difference being the one in the later handles the case where len(Q2) <= 1.

https://github.com/PySloth/pysloth/blob/463620d890555191b6ec2c14593f181b9b80d615/etc/old_icpd_repo/SCPD.py#L90

I think this is the expected behavior and we should use this version of the function instead?