search

PySlurm / pyslurm

Python Interface to Slurm
https://pyslurm.github.io
GNU General Public License v2.0
474 stars 116 forks source link

Fixed mem_per_cpu setting in job class #243

Closed JonaOtto closed 1 year ago

JonaOtto commented 1 year ago

Hello pyslurm developers, This PR fixes the false renaming of the mem_per_cpu setting in some of the job class functions, which was called mem_per_cp. This is a/the similar problem that was concerned in #241.

Since this problem is part of multiple versions (at least 22.05 and 21.08 as far as I checked), and we did it this way in my last contribution, I do this against base branch main, for you to easily back port it. If you want a different branch, let me know, I could change the base branch then.

Thanks :)

Best, Jonathan

JonaOtto commented 1 year ago

Apparently there are some more things that still had mem_per_cp as part of their name (max_mem_per_cpu and req_mem_per_cpu). I fixed them all over the pyslurm.pyx file. Hopefully there is no mem_per_cp left now.

tazend commented 1 year ago

Hi, alright looks good thanks for catching it :). I will then also get this to the 21.08 branch.

JonaOtto commented 1 year ago

Perfect, thanks :+1: