PySpice-org / PySpice

Simulate electronic circuit using Python and the Ngspice / Xyce simulators
https://pyspice.fabrice-salvaire.fr
GNU General Public License v3.0
641 stars 169 forks source link

Pyspice examples are not included in pre-release testing #366

Open wahuneke opened 4 months ago

wahuneke commented 4 months ago

Using the latest release, there are some minor errors in some of the examples (e.g. matplotlib compatibility). This raises the general question:

as part of pre-release test, would you like examples to be run and some cursory confirmation performed ?

Has this idea already been considered and rejected for some reason? If not, I propose I go ahead with something like the following.

Proposal

Add a unit test which attempts to run each example. For each one perform cursory checks - at least confirm that the it ran without exceptions. As an added feature, we could consider confirming (for examples where this applies) that plot files were successfully generated and that they meet some basic requirement (non-zero size?). The goal would be to provide a minimal sanity check

Thoughts?