Add InterceptionEvent - Githubissues

PySport / kloppy

kloppy: standardizing soccer tracking- and event data

https://kloppy.pysport.org

BSD 3-Clause "New" or "Revised" License

328 stars 55 forks source link

Add InterceptionEvent #230

Closed MKlaasman closed 8 months ago

MKlaasman commented 8 months ago

fixes #222

Notes:

Whenever needed (wyscout & opta), I inferred the InterceptionResult from the next event. Though, this approach might still be suboptimal.
In WyScout v2: The orginal RecoveryEvent gets overwritten by the InterceptionEvent, whenever possible

What do you think? @probberechts @JanVanHaaren

MKlaasman commented 8 months ago

Addition: 1) Wyscout v2: Now duels and touches are overwritten with InterceptionEvent when they have an interception tag. 2) Opta: Handle a blocked pass as an interception. 3) Opta: Filtered deleted events upfront, otherwise next_event implementation prone for wrong InterceptionResult. Now, not logging the Skipping of events anymore. Someone, thinking this is a bad design choice?

koenvo commented 8 months ago

@MKlaasman thanks for your work. Can you please merge master in? There are some small merge conflicts due to changes from Pieters PRs.