Fix Wyscout deserialization of teams and players

PySport / kloppy

kloppy: standardizing soccer tracking- and event data

https://kloppy.pysport.org

BSD 3-Clause "New" or "Revised" License

328 stars 55 forks source link

Fix Wyscout deserialization of teams and players #235

Closed probberechts closed 7 months ago

probberechts commented 8 months ago

The structure of the Wyscout v2 test file does not correspond to the specs in the official documentation. This commit fixes the test file and adapts the deserializer accordingly.

Fixes #234

probberechts commented 7 months ago

I noticed that this PR will break loading the Wyscout open data. The preprocessed version of this dataset in koenvo/wyscout-soccer-match-event-dataset would have to be updated as well.

koenvo commented 7 months ago

Thanks for this fix!

Let me see how to update this on the open data part. Will probably need to generate a new set under a different directory in the repository and point kloppy to the new location.