search

PySport / kloppy

kloppy: standardizing soccer tracking- and event data
https://kloppy.pysport.org
BSD 3-Clause "New" or "Revised" License
328 stars 55 forks source link

The SkillCorner tracking data deserializer expects a .json file but raw data is in .jsonl format #251

Closed DriesDeprest closed 7 months ago

DriesDeprest commented 7 months ago

The SkillCorner tracking data deserializer expects a .json file, see: https://github.com/PySport/kloppy/blob/master/kloppy/infra/serializers/tracking/skillcorner.py#L254. While the raw input SkillCorner files received from the API are in .jsonl format: https://skillcorner.com/api/docs#/match/match_tracking_list.

Is this the result of SkillCorner having updated the format in which they share tracking data?

JanVanHaaren commented 7 months ago

I believe that SkillCorner changed their output format at some point. I haven't checked, but the current implementation should be compatible with the SkillCorner Open Data format. Pull request #215 is related.

DriesDeprest commented 7 months ago

Okay, thanks for sharing Jan! I'll continue the discussion over there.