Fix FoulComitted + Card for Wyscout v2

probberechts commented 7 months ago

No FoulComitted event was recorded when a card was given. To be consistent with the other data providers both a FoulCommittedEvent and CardEvent are recorded now.
Adds CardQualifiers to the FoulCommittedEvent.

probberechts commented 6 months ago

I made a few more changes:

Refactored the Wyscout tests such that you have one unit test per action type
Use IDs instead of indexes to select events in the tests, which is much easier to maintain and to find the relevant data record in the test data
Removed a few duplicate IDs in the Wyscout v3 test data
Fixed the scope of the base_dir fixture. There is no need to recreate a constant for each function, so I've changed the scope to "session".
Added a test for FoulCommited + Card events
Added a prefix to the ID of synthetic events to avoid having multiple events with the same ID
Changed the type of event IDs from int to str. This is consistent with the defined type of event IDs.

koenvo commented 6 months ago

Great work @probberechts! Can you merge current master in and resolve conflicts?

PySport / kloppy