Refactor StatsBomb deserializer

probberechts commented 9 months ago

Started with a small bugfix, ... ended up with a complete rewrite 😬

refactor: Split up StatsBombDeserializer.deserialize method
refactor: Group code for deserializing events per StatsBomb event type
refactor: Reorganize constants for StatsBomb event types and outcomes in a hierarchical structure
refactor: Group tests per StatsBomb event type
test: Load data from open data repository to automatically catch data updates
test: Add unit tests for each deserialized event type
fix: An interception before a pas must always be successful. Previously, the result of the pass was used.
fix: Do not throw away bad behaviour events without a card, map them to a generic event
fix: Incorrect card ids. In the open data, the following IDs are used: 7/Yellow Card, 6/Second Yellow, 5/Red. This is incorrect in the documentation.
fix: Add BALL_STATE flag to metadata
fix: Add prefix to synthetic events to avoid duplicate event IDs
fix: The get_qualifier_values method returned qualifiers instead of qualifier values
fix: Interceptions do not have a body part.
fix: Duels do not have a body part.
fix: The set of synthetically-generated ball out events was very incomplete.
fix: StatsBomb has no Dribble.OUT outcome. The TakeOnResult.OUT result must be derived from the related duel.
fix: Freeze frame coordinates should be parsed with the shot fidelity version.

JanVanHaaren commented 9 months ago

Thank you very much, @probberechts. I will review this pull request as soon as possible.

koenvo commented 9 months ago

Great work. I really like the approach with the intermediate SB format!

PySport / kloppy