search

PySport / kloppy

kloppy: standardizing soccer tracking- and event data
https://kloppy.pysport.org
BSD 3-Clause "New" or "Revised" License
328 stars 55 forks source link

Redo of #PR215 #278

Closed UnravelSports closed 5 months ago

UnravelSports commented 6 months ago

Because I made a mess of PR https://github.com/PySport/kloppy/pull/215, here is a clean attempt. It includes updated jsonl loader without with open(), Dries' minor changes to IDs as proposed in https://github.com/PySport/kloppy/commit/277a7143566df9f05cef5b1d66a353cadcb0f4ba and updated event_factory.

JanVanHaaren commented 6 months ago

Thanks, @UnravelSports! The changes to the SkillCorner deserializer look good to me.

Could you please fix the code formatting? I suspect that the formatting changes to the event data deserializers were unintentional.

JanVanHaaren commented 6 months ago

@UnravelSports I've managed to make the necessary changes myself. 😊

UnravelSports commented 6 months ago

@JanVanHaaren for future reference, what formatting was wrong? Because I did run black on all the files, so kinda curious where it went wrong

Thanks for fixing it and approving of the changes!

JanVanHaaren commented 6 months ago

@JanVanHaaren for future reference, what formatting was wrong? Because I did run black on all the files, so kinda curious where it went wrong

Good question. I suspect that you're using a different version of black that has slightly different default preferences, but I'm not entirely sure.

UnravelSports commented 6 months ago

Good point, I'll update :)