search

PySport / kloppy

kloppy: standardizing soccer tracking- and event data
https://kloppy.pysport.org
BSD 3-Clause "New" or "Revised" License
328 stars 55 forks source link

Add shot assist to data model and fix Opta & StatsBomb deserializers accordingly #281

Closed DriesDeprest closed 3 months ago

DriesDeprest commented 6 months ago

PR related to https://github.com/PySport/kloppy/issues/239.

I've added SHOT_ASSIST as a possiblePassType to our data model and fixed the Opta & StatsBomb deserializers accordingly. We now correctly make a distinction between a shot assist and (goal) assist.

I was in doubt on whether we wanted to rename ASSIST to GOAL_ASSIST to be more explicit in our naming, but didn't do it as I didn't want to introduce breaking changes.

I also chose to add both a SHOT_ASSIST and ASSIST qualifier to a goal assist, you could argue to only add ASSIST qualifier to a goal assist. I don't have a strong preference on that.

DriesDeprest commented 5 months ago

@JanVanHaaren @koenvo any updates on this PR? Wondering what your thoughts are on this.