search

PyThaiNLP / pythainlp

Thai Natural Language Processing in Python.
https://pythainlp.org/
Apache License 2.0
975 stars 272 forks source link

Fix tests of khavee functions #854

Closed BLKSerene closed 11 months ago

BLKSerene commented 11 months ago

What does this changes

This PR fixes tests of khavee functions and conduct more code cleanups.

What was wrong

A regression is introduced when updating code comments and conducting code cleanups in #845.

How this fixes it

Extra space is added when joining parts of printed message to be consistent with other printed messages.

Fixes #853

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

pep8speaks commented 11 months ago

Hello @BLKSerene! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2023-10-23 08:56:15 UTC
sonarcloud[bot] commented 11 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
43.8% 43.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

wannaphong commented 11 months ago

Thank you! 💯