PyThaiNLP / pythainlp

Thai Natural Language Processing in Python.
https://pythainlp.org/
Apache License 2.0
936 stars 272 forks source link

switch PyThaiNLP source code to SPDX license ID #876

Closed pavaris-pm closed 7 months ago

pavaris-pm commented 7 months ago

What does this changes

According to issue #874 , in this PR, i already switch the license to SPDX already by replacing it with the new one as mentioned in that issue krub. Tag @bact since i have made changes and you are an issue owner. You can take a review at it and inform me if i miss something in the source code krub.

Fix #874

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

coveralls commented 7 months ago

Coverage Status

coverage: 86.133% (+0.03%) from 86.104% when pulling f86c23b5dddfbf5783601d58d76728487d6b8b8c on pavaris-pm:update-license into f877567bc9ba26f3a6ee03d7418a2f5e0c0ec535 on PyThaiNLP:dev.

bact commented 7 months ago

Thank a lot @pavaris-pm . This is so fast.

Do you mind to changes two things please?:

1) Using this copyright text line instead:

SPDX-FileCopyrightText: Copyright 2016-2023 PyThaiNLP Project

(I decided to follow template in SPDX website)

2) Also replace the license text in setup.py

Thank you.

pavaris-pm commented 7 months ago

Thank a lot @pavaris-pm . This is so fast.

Do you mind to changes two things please?:

1) Using this copyright text line instead:


SPDX-FileCopyrightText: Copyright 2016-2023 PyThaiNLP Project

(I decided to follow template in SPDX website)

2) Also replace the license text in setup.py

Thank you.

Roger that, I will add it accordingly within today krub.

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pavaris-pm commented 7 months ago

@bact i already add and update according to your review. please review my latest push krub.