Fix coref return type and add fallback

PyThaiNLP / pythainlp

Thai Natural Language Processing in Python.

https://pythainlp.org/

Apache License 2.0

975 stars 272 forks source link

Fix coref return type and add fallback #883

Closed bact closed 10 months ago

bact commented 10 months ago

coref: Fix FastCoref.predict() return type
coref: Make sure that coreference_resolution() returns something valid, even if it failed to get a model
Fix typos in docstring
classify: was cls, rename for naming consistency - pythainlp.cls is still accessible for backward compatibility (with deprecated warning)
General code formatting and import sorting
Add ruff config

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

[x] Passed code styles and structures
[ ] Passed code linting checks and unit test

review-notebook-app[bot] commented 10 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

pep8speaks commented 10 months ago

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pythainlp/chat/core.py:

Line 86:21: W503 line break before binary operator

Comment last updated at 2023-12-07 02:05:20 UTC

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

coveralls commented 10 months ago

coverage: 84.154% (-0.01%) from 84.166% when pulling c8d643f2eb00015f044041b8469a0f40d3482f85 on bact:dev into 9bd951b984107604e9df85afbdccca38b7b143b2 on PyThaiNLP:dev.