Closed varunkatiyar819 closed 3 months ago
Hello @varunkatiyar819! Thanks for updating this PR. We checked the lines you've touched for PEPÂ 8 issues, and found:
pythainlp/tokenize/crfcut.py
:Line 207:35: E226 missing whitespace around arithmetic operator
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
It look the test is break. Can you fix? @varunkatiyar819
['ฉันไปโรงเรียน เธà¸à¹„ปโรงพยาบาล'] != ['ฉันไปโรงเรียน ', 'เธà¸à¹„ปโรงพยาบาล']
Logic for the Code is been modified and tested as well. Please do have a check. Thanks
Crfcut creating issues for split using terminal punctuation commonly '.' (full stop) which should be treated as end of the sentence, Modified the function such that it should split using terminal punctuations and avoid any kind of empty strings.
What does this changes
Brief summary of the changes
What was wrong
Description of what was the root cause of the issue.
How this fixes it
Description of how the changes fix the issue.
Fixes #904
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.