PyThaiNLP / pythainlp

Thai Natural Language Processing in Python.
https://pythainlp.org/
Apache License 2.0
936 stars 272 forks source link

[WIP] Add save and load for pythainlp.classify.param_free.GzipModel #908

Open wannaphong opened 2 months ago

wannaphong commented 2 months ago

Add save and load model for pythainlp.classify.param_free.GzipModel

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

pep8speaks commented 2 months ago

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 20:60: E252 missing whitespace around parameter equals Line 20:61: E252 missing whitespace around parameter equals Line 20:82: E252 missing whitespace around parameter equals Line 20:83: E252 missing whitespace around parameter equals Line 21:22: E225 missing whitespace around operator Line 21:22: E711 comparison to None should be 'if cond is not None:' Line 84:27: E231 missing whitespace after ':' Line 90:28: E222 multiple spaces after operator

Comment last updated at 2024-05-06 17:17:30 UTC
coveralls commented 2 months ago

Coverage Status

coverage: 79.04% (-0.02%) from 79.063% when pulling b09e8bdaa715e0e2f23d7e9d642e701ee90be8e0 on add-save-load-param_free into 13a6c7c84aec4eff0d22a845dcdb6c630e34502e on dev.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 4 weeks ago

This PR is stale because it has been open for 30 days with no activity.