search

PyUtilib / pyutilib

A collection of general Python utilities, including logging and file IO, subprocess management, plugin systems, and workflow management.
BSD 3-Clause "New" or "Revised" License
34 stars 21 forks source link

Ensure proper execution of subprocesses on MS Windows #22

Open whart222 opened 8 years ago

whart222 commented 8 years ago

The subprocess.run command either does not return the appropriate value or it does not generate output. This branch is focused on resolving this discrepancy.

ghackebeil commented 8 years ago

What do you mean? We've been using this for quite some time and it seems to work fine.

I'm confused by the commit referenced above as well. The Appveyor tests have been fixed in that failed tests are now reflected in the return code. What was the above commit fixing?

whart222 commented 8 years ago

Gabe:

I didn't realize that your commits fixed the return code. But in any case the output is being masked on MS Windows. So there's still an issue that needs to be resolved.

--Bill

On Wed, Jul 6, 2016 at 4:48 PM, Gabriel Hackebeil notifications@github.com wrote:

What do you mean? We've been using this for quite some time and it seems to work fine.

I'm confused by the commit referenced above as well. The Appveyor tests have been fixed in that failed tests are now reflected in the return code. What was the above commit fixing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PyUtilib/pyutilib/issues/22#issuecomment-230901600, or mute the thread https://github.com/notifications/unsubscribe/AAsb-NlYQr5LXyXCMCfH6Mvf4x8_yaZnks5qTBSggaJpZM4JGcyV .

ghackebeil commented 8 years ago

Agreed. Maybe we should rename this ticket to reflect that. The problem is with output redirection, not the return code.

On Jul 6, 2016, at 4:50 PM, William Hart notifications@github.com wrote:

Gabe:

I didn't realize that your commits fixed the return code. But in any case the output is being masked on MS Windows. So there's still an issue that needs to be resolved.

--Bill

On Wed, Jul 6, 2016 at 4:48 PM, Gabriel Hackebeil notifications@github.com wrote:

What do you mean? We've been using this for quite some time and it seems to work fine.

I'm confused by the commit referenced above as well. The Appveyor tests have been fixed in that failed tests are now reflected in the return code. What was the above commit fixing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PyUtilib/pyutilib/issues/22#issuecomment-230901600, or mute the thread https://github.com/notifications/unsubscribe/AAsb-NlYQr5LXyXCMCfH6Mvf4x8_yaZnks5qTBSggaJpZM4JGcyV .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.