Closed jsiirola closed 4 years ago
This PR is meant to seed a discussion around managing test suites. This is a 1-line PR with a fairly significant impact. As such, I am hoping to hear from all the reviewers before we entertain merging it.
Merging #46 into master will not change coverage. The diff coverage is
0%
.
@@ Coverage Diff @@
## master #46 +/- ##
=======================================
Coverage 64.94% 64.94%
=======================================
Files 87 87
Lines 8726 8726
=======================================
Hits 5667 5667
Misses 3059 3059
Impacted Files | Coverage Δ | |
---|---|---|
pyutilib/th/pyunit.py | 47.93% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2e25e1d...72ff932. Read the comment docs.
Summary/Motivation:
Currently uncategorized pyutilib.th tests default to "smoke, nightly, expensive". This means that the "expensive" test jobs duplicate all of the tests that the smoke/nightly test jobs have already done, which seems redundant ('all' covers that use case). This PR changes the default so that uncategorized tests are marked as "smoke, nightly," but not expensive. This will reduce the amount of unnecessarily repeated tests in most testing setups.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: