PyUtilib / pyutilib

A collection of general Python utilities, including logging and file IO, subprocess management, plugin systems, and workflow management.

BSD 3-Clause "New" or "Revised" License

34 stars 21 forks source link

Uncategorized tests should not default to expensive #46

Closed jsiirola closed 4 years ago

jsiirola commented 5 years ago

Summary/Motivation:

Currently uncategorized pyutilib.th tests default to "smoke, nightly, expensive". This means that the "expensive" test jobs duplicate all of the tests that the smoke/nightly test jobs have already done, which seems redundant ('all' covers that use case). This PR changes the default so that uncategorized tests are marked as "smoke, nightly," but not expensive. This will reduce the amount of unnecessarily repeated tests in most testing setups.

Changes proposed in this PR:

remove "expensive" as a default category

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

jsiirola commented 5 years ago

This PR is meant to seed a discussion around managing test suites. This is a 1-line PR with a fairly significant impact. As such, I am hoping to hear from all the reviewers before we entertain merging it.

coveralls commented 5 years ago

Coverage remained the same at 64.004% when pulling 72ff932e965fa61f6337afeb7ac5c7709533db22 on nightly_not_expensive into 2e25e1d2dcf195e8af6fe1cd34f5e4296050fa55 on master.

coveralls commented 5 years ago

Coverage remained the same at 64.004% when pulling 72ff932e965fa61f6337afeb7ac5c7709533db22 on nightly_not_expensive into 2e25e1d2dcf195e8af6fe1cd34f5e4296050fa55 on master.

coveralls commented 5 years ago

Coverage remained the same at 64.004% when pulling 72ff932e965fa61f6337afeb7ac5c7709533db22 on nightly_not_expensive into 2e25e1d2dcf195e8af6fe1cd34f5e4296050fa55 on master.

coveralls commented 5 years ago

Coverage remained the same at 64.004% when pulling 72ff932e965fa61f6337afeb7ac5c7709533db22 on nightly_not_expensive into 2e25e1d2dcf195e8af6fe1cd34f5e4296050fa55 on master.

codecov-io commented 5 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   64.94%   64.94%           
=======================================
  Files          87       87           
  Lines        8726     8726           
=======================================
  Hits         5667     5667           
  Misses       3059     3059

Impacted Files	Coverage Δ
pyutilib/th/pyunit.py	`47.93% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e25e1d...72ff932. Read the comment docs.