search

PyUtilib / pyutilib

A collection of general Python utilities, including logging and file IO, subprocess management, plugin systems, and workflow management.
BSD 3-Clause "New" or "Revised" License
34 stars 21 forks source link

Fix for PR #53 so yaml tests run with pyyaml<5.1 #55

Closed jsiirola closed 5 years ago

jsiirola commented 5 years ago

Fixes: N/A

Summary/Motivation:

PR #53 resolved deprecation warnings with recent PyYAML, but broke tests for PyYAML<5.1. This PR resolves those test failures so that tests run cleanly for new and old versions od PyYAML.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 62.245% when pulling 4cdaf4acd33dd394f2364e9080c1782100828be9 on fix-yaml-tests into 7223482aba1c75378ae5e77f35a16440bbb8fb31 on master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 62.245% when pulling 4cdaf4acd33dd394f2364e9080c1782100828be9 on fix-yaml-tests into 7223482aba1c75378ae5e77f35a16440bbb8fb31 on master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 62.245% when pulling 4cdaf4acd33dd394f2364e9080c1782100828be9 on fix-yaml-tests into 7223482aba1c75378ae5e77f35a16440bbb8fb31 on master.

whart222 commented 5 years ago

The PR doesn't motivate the need for this fix. In general, we are not going to be able to support backwards compatibility in all cases for third-party libraries. So what's the motivation here? I know that this impacts Pyomo development, and I expect similar backwards compatibility issues to arise there as well.