PyUtilib / pyutilib

A collection of general Python utilities, including logging and file IO, subprocess management, plugin systems, and workflow management.
BSD 3-Clause "New" or "Revised" License
34 stars 20 forks source link

Fixes to setup.py and setup.cfg #75

Closed mrmundt closed 4 years ago

mrmundt commented 4 years ago

Fixes:

This PR removes an unnecessary _find_packages routine from the setup.py file.

Summary/Motivation:

We want to use the built-in capabilities of setuptools for packaging PyUtilib and include the LICENSE file when packaging (mostly for Conda distribution).

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.08%) to 61.001% when pulling 388e7bc9e52e72d708a780522d3d9aebb43bbf10 on mrmundt:setup_fixes into 5763915b62477c911cba2eae4de227a97171fe8d on PyUtilib:master.

codecov-io commented 4 years ago

Codecov Report

Merging #75 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   62.85%   62.85%           
=======================================
  Files          87       87           
  Lines        8777     8777           
=======================================
  Hits         5517     5517           
  Misses       3260     3260

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5763915...388e7bc. Read the comment docs.

blnicho commented 4 years ago

Does this fix #72?