search

PyWavelets / pywt

PyWavelets - Wavelet Transforms in Python
http://pywavelets.readthedocs.org
MIT License
1.97k stars 460 forks source link

release v1.4.1, updating classifiers and python_requires in setup.py #657

Closed grlee77 closed 1 year ago

grlee77 commented 1 year ago

I think we should just go ahead and do a 1.4.1 patch release since I missed updating python_requires in 1.4.0.

rgommers commented 1 year ago

Ah yes, I missed that too. Good point, agreed a v1.4.1 is a good idea. I pushed one more commit with 3.7 cleanups in pyproject.toml.

grlee77 commented 1 year ago

Thanks! I will go ahead and push a tag to kick of the wheel builds

grlee77 commented 1 year ago

I expect we may get some complaints related to Python 3.7 since 1.4.0 will likely try to build from source since we didn't provide wheels for it, but the python_requires still allowed it.

I guess we just suggest those on 3.7 pin to pywavelets<1.4? (I don't think we want to go back and add the 3.7 wheels to 1.4.0 and fully deleting that release from PyPI seems a bit drastic)

rgommers commented 1 year ago

We can yank the 1.4.0 release. That way you leave the binaries in place, but users will only get them if they use the exact version number, like pip install pywavelets==1.4.0.

rgommers commented 1 year ago

All looks good now, thanks again for doing this release @grlee77