PyWiFeS / pipeline

The Python data reduction pipeline for WiFeS
6 stars 26 forks source link

Minor change to generate_metadata_script.py to find bias files #26

Closed tansb closed 7 months ago

tansb commented 8 months ago

Hi, I had some observations taken 18th October 2023 and I noticed my bias frames weren't being picked up by generate_metadata_script.py because the IMAGETYP in the fits headers is called BIAS and not ZERO. Perhaps this is a change with recent observations. I've updated the generate_metadata_script.py file to look for either a BIAS or ZERO imagetype keyword.

Thanks, Tania

clidman commented 8 months ago

Thanks, Tanya.

I understand that Cristina, Tim, and Luke have a version that takes into account the change in the headers. I'll let them reply to this request.

CMartinezLombilla commented 8 months ago

Hi Tania,

Thank you for your work! As Chris said, we're currently working on developing an automated version of the pipeline so we're fixing all these issues. We do have a working version with the new headers that will be available in the 'automation' branch very soon, we're just waiting for a final review. I can let you know once this is available (i.e. in the next few days). Just take into account that we're still working on the pipeline so there might be issues. Please, if you use our developing version, let us know any issue or improvement you would like us to consider.

Thank you again! Cristina.

timothyfrankdavies commented 8 months ago

These changes seem separate to the other header changes, maybe we should include both?

Also, with all these header changes, I'm not sure if we need backwards compatibility, or if only the most recent observations need supporting.

CMartinezLombilla commented 8 months ago

These changes in generate_metadata_script.py are not reflected in the most recent update of the headers because they were already changed in the very first debugging of the pipeline to be able to do some tests, so they were implemented a couple of months ago. Now, all the issues regarding the headers at all stages of the pipeline should be solved in the branch cml_fix_headers.