Closed felipeji closed 2 months ago
Thank you for your feedback. I've implemented nearly all of your suggestions and conducted some reduction tests to validate the changes. Specifically, I focused on reducing only one arm at time and using parameters set by the user (i.e. with the path to the JSON pass in the command line). Please, let me know your thoughts regarding the prints and the others comments a left along the review.
Thank you! Much better and clearer now. Great that you spotted the typo! I've updated a bit more the readme file. I'd say you're good to go with the merge now.
This PR includes a few changes related to the selection of pipeline parameters from JSON files based on the grism used for observation. The main changes are as follows:
All JSON files are now located in the
reduction_scripts/pipeline_params directory
. JSON files containing extraction parameters remain in this directory, while those containing pipeline parameters are now split into corresponding arm directories (blue or red). The names of the JSON files now also include the name of the grism, for example, B3000.reduce_data.py
has been updated to follow the new directory structure described above. The grism used fro the observation is read from the header of the first science image and then used to load the parameters from the corresponding JSON file.A new structure has been implemented for parsing inline parameters using
argparse
. This structure now includes optional flags--red_params
and--blue_params
, allowing the user to pass a customized JSON file for each arm when reducing the data."