PyWiFeS / pipeline

The Python data reduction pipeline for WiFeS
6 stars 26 forks source link

Fji gratings #53

Closed felipeji closed 2 months ago

felipeji commented 3 months ago

This PR includes a few changes related to the selection of pipeline parameters from JSON files based on the grism used for observation. The main changes are as follows:

felipeji commented 2 months ago

Thank you for your feedback. I've implemented nearly all of your suggestions and conducted some reduction tests to validate the changes. Specifically, I focused on reducing only one arm at time and using parameters set by the user (i.e. with the path to the JSON pass in the command line). Please, let me know your thoughts regarding the prints and the others comments a left along the review.

CMartinezLombilla commented 2 months ago

Thank you! Much better and clearer now. Great that you spotted the typo! I've updated a bit more the readme file. I'd say you're good to go with the merge now.