PyWorkflowApp / visual-programming

A Python Visual Programming Workspace for Data Science
MIT License
33 stars 12 forks source link

Use server load/save endpoints from front end #28

Closed reddigari closed 4 years ago

reddigari commented 4 years ago
reddigari commented 4 years ago

@reelmatt Hmmm I can't seem to replicate it. Can you take a screen recording?

reelmatt commented 4 years ago

Slightly different behavior then what I was experiencing earlier. I can get it to clear and load (unlike before), but a second clear seems to cause a problem? My thinking was it was whatever 'clear' was doing, but that doesn't seem to be the case.

Original screen recording

Edit: I think I may have found the actual problem. It's not with the clearing as I original though, but re-loading the same diagram back in. General steps to reproduce seem to be:

  1. Load diagram 1
  2. Clear
  3. Load diagram 1 (fails)
  4. Load diagram 2 (succeeds)
  5. Clear
  6. Load diagram 2 (fails)

New screen recording

reddigari commented 4 years ago

Excellent catch. The event listener is for onchange, so if you select the same file, the listener doesn't fire. I'll fix it to reset the file between each event.