Front-end refactoring - Githubissues

PyWorkflowApp / visual-programming

A Python Visual Programming Workspace for Data Science

MIT License

33 stars 12 forks source link

Front-end refactoring #38

Closed reddigari closed 4 years ago

reddigari commented 4 years ago

Move all API calls to functions in separate file. Allows other components to use API.createNode(), e.g., instead of making XHR requests and handling responses in the component. (Reduces footprint of Workspace component by almost half.)
- All functions are async and return a promise that resolves to the expected JSON data, or rejects to the server's JSON error message
Refactors the node menu components into their own file
Minor diagram style tweaks

reddigari commented 4 years ago

@reelmatt I think you're right --- I wrestled with that idea, and the nested and chained then/catches always look kinda gross, but the functions repeat themselves so much that it's probably worthwhile. The complicated ones can just handle the data after the call to ourFetch.

Updates coming shortly.

reddigari commented 4 years ago

I think we're good, but if someone wants to double-check that I didn't break any functionality with the last commits before it's merged, that'd be great.

reelmatt commented 4 years ago

Looks good to me!