PyWorkflowApp / visual-programming

A Python Visual Programming Workspace for Data Science
MIT License
31 stars 12 forks source link

Potential clobbering with Workflow name (UUID, or custom) #51

Open reelmatt opened 4 years ago

reelmatt commented 4 years ago

The workflow name (now set to the DiagramModel UUID by default) appears in 1) Save file — {workflow name}.json 2) Executed Node data — {workflow name}-{node id}

Files uploaded during Node configuration (e.g. ReadCsv) are given a name {node-id}-{original file name}.

For the use case @reddigari mentioned in #49, using same workflow UUID shouldn't be a problem when writing files? If the user does clear the diagram and builds another, the node IDs should differ to prevent clobbering. Relatedly, if this is a problem, it should manifest when executing the same workflow twice and I haven't seen any problems in this regard yet.

The more "ideal" scenario though, is one where the user names their workflow (perhaps prompted when initWorkflow is triggered?) instead of the UUID. I can actually see this as more of a problem in that it'd be more common the same/different users choose 'MySimpleWorkflow' as a name instead of the UUID react-diagrams generates.