PyWorkflowApp / visual-programming

A Python Visual Programming Workspace for Data Science
MIT License
33 stars 12 forks source link

Initial upload/instantiation of custom nodes #66

Closed reelmatt closed 4 years ago

reelmatt commented 4 years ago

We probably want to hold off on merging until we figure some issues out, but this PR has an implementation of adding custom nodes. Other approaches/questions are discussed in #67.

What this does

What this does not do/things to fix

reelmatt commented 4 years ago

Latest commits don't change much from the initial PR. It does refactor a lot of node-parsing code (with check_missing_packages being a notable duplicated method still).

The latest commits add Custom Nodes to the same GET /nodes endpoint for the node listing. It does this through a second, separate, for loop for files within pyworkflow/custom_nodes/.

reelmatt commented 4 years ago

I'm working on a refactored approach that handles Nodes differently than this PR. Closing for now, but we can revert to this state of implementation if the refactor is too problematic.